Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(optional-policies): resolve null property warnings and improve UX #61

Merged
merged 11 commits into from
Dec 9, 2024
Merged

fix(optional-policies): resolve null property warnings and improve UX #61

merged 11 commits into from
Dec 9, 2024

Conversation

rafaucau
Copy link
Contributor

@rafaucau rafaucau commented Dec 4, 2024 •
edited
Loading

@rafaucau rafaucau changed the title fix(optional-policies): resolve Attempt to read property "is_accepted" on null warnings fix(optional-policies): resolve Attempt to read property "is_accepted" on null warnings, make user policies settings section translatable and other small fixes Dec 4, 2024
@rafaucau rafaucau changed the title fix(optional-policies): resolve Attempt to read property "is_accepted" on null warnings, make user policies settings section translatable and other small fixes fix(optional-policies): resolve null property warnings and improve settings UI Dec 4, 2024
@rafaucau rafaucau changed the title fix(optional-policies): resolve null property warnings and improve settings UI fix(optional-policies): resolve null property warnings and improve UX Dec 5, 2024
@rafaucau rafaucau marked this pull request as ready for review December 5, 2024 11:55
DavideIadeluca
DavideIadeluca approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@DavideIadeluca DavideIadeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test locally. But the changes make sense to me

@DavideIadeluca DavideIadeluca merged commit cb5652f into FriendsOfFlarum:master Dec 9, 2024
7 checks passed
@rafaucau rafaucau deleted the fix/optional-policies.2 branch December 9, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavideIadeluca DavideIadeluca DavideIadeluca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaucau @DavideIadeluca